[Konsole-devel] Review Request 124142: Fix storing of changed default profile

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124142/
-----------------------------------------------------------

(Updated July 4, 2015, 4:12 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 4ec5d3092d6cbda5ccfb838e2ef71f6d650b5ac4 by Martin T. H. Sandsmark to branch master.


Bugs: 303356
    http://bugs.kde.org/show_bug.cgi?id=303356


Repository: konsole


Description
-------

If for some reason no profile is loaded, i. e. only the built-in
fallback default values are used, we need to create a new profile to
ensure that changes to the profile are actually persisted.

This has worked more or less by chance for most people so far, because
the default is to load the Shell.profile that is shipped with Konsole.
But if for example the konsolerc config file has an empty value for
DefaultProfile it will load the builtin fallback profile, which can't be
saved.


Diffs
-----

  src/Profile.cpp 13c51c8 
  src/ProfileManager.cpp 0a3c125 

Diff: https://git.reviewboard.kde.org/r/124142/diff/


Testing
-------

Deleted all profiles, set empty DefaultProfile in konsolerc, change some settings in the profile, close konsole, and restart konsole and see that my changes persist.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150704/55fa146a/attachment.html>