[Konsole-devel] Review Request 121399: Change icon of MainWindow, if the session icon changes

[Alexander Sulfrian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121399/
-----------------------------------------------------------

(Updated Jan. 25, 2015, 12:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole.


Bugs: 325413
    http://bugs.kde.org/show_bug.cgi?id=325413


Repository: konsole


Description
-------

Currently the MainWindow icon only updates if the window title changes, too. This is problematic, if the icon changes on other dependencies. Such dependencies would be the activity monitor or the icon change if the user toggles the "Send to all" feature. In such cases the icon of the tab changes, but the icon of the MainWindow and so the icon in the taskbar does not change.

This patch promotes the icon changes from the SessionController to the MainWindow.


Diffs
-----

  src/MainWindow.cpp 6e47939 

Diff: https://git.reviewboard.kde.org/r/121399/diff/


Testing
-------

Build, run Konsole. Open two tabs and activate "Sent to all" feature.


Thanks,

Alexander Sulfrian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150125/7299e45c/attachment-0001.html>