[Konsole-devel] Review Request 121679: Konsole: port from KonqOperations to the new KIO::DropJob

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121679/#review73751
-----------------------------------------------------------

Ship it!


Looks fine to me - note that the patch doesn't apply clean w/ other cleanups that have been committed lately.  let me know if you want me to commit

- Kurt Hindenburg


On Dec. 26, 2014, 8:37 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121679/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 8:37 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This allows to get rid of the libkonq dependency completely.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b22e733defce5a2dae1f7afa784b84434bdae046 
>   src/TerminalDisplay.cpp 74f4ec12b29eb3e1de04044007d75a75705521ea 
>   src/config-konsole.h.cmake c025a0da0e6787b2f20b5510cceb8b79cac9b3df 
> 
> Diff: https://git.reviewboard.kde.org/r/121679/diff/
> 
> 
> Testing
> -------
> 
> Dropping from KF5-based dolphin, and choosing Copy (works), or choosing Paste Location (works).
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150111/daea26d3/attachment.html>