[Konsole-devel] Review Request 121630: [konsole] Remove last bits of KDELibs4Support

[Christoph Feck]

> On Jan. 3, 2015, 3:51 a.m., Kurt Hindenburg wrote:
> > On my system, it doesn't build w/ the path.  I'll look at this more over the weekend.
> 
> Kurt Hindenburg wrote:
>     I committed the QFontDatabase
>     
>     I still get a lot of errors about KTabWidget if KDelibs4support is removed - are you running w/ another patches?

Nope, but it looks like on my distribution KF5 headers are all installed into a single place, so some headers are found even while not importing them explicitly in the CMake files. I am going to discard this request, please pick other changes whenever you think they are appropriate.

Regarding the QFontDatabase pick, I think you can avoid including KGlobalSettings now.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121630/#review72997
-----------------------------------------------------------


On Dec. 22, 2014, 12:58 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121630/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2014, 12:58 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This remove compilation and linking against KDELibs4Support.
> 
> Replaces KGlobalSettings::smallestReadableFont() with QFontDatabase::systemFont().
> 
> Also, some minor include changes.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5334e3c 
>   src/CMakeLists.txt b22e733 
>   src/MainWindow.cpp 7333ef8 
>   src/Part.h 646e3aa 
>   src/ProfileManager.cpp 78e1a81 
>   src/TerminalDisplay.cpp 74f4ec1 
> 
> Diff: https://git.reviewboard.kde.org/r/121630/diff/
> 
> 
> Testing
> -------
> 
> Compiles and still works.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150105/a6420204/attachment.html>