[Konsole-devel] [konsole] [Bug 344110] New: new tab NOT uses the same working directory as current tab (when midnight-commander is running)

zsovig zsovig at yahoo.com
Fri Feb 13 11:27:41 UTC 2015


https://bugs.kde.org/show_bug.cgi?id=344110

            Bug ID: 344110
           Summary: new tab NOT uses the same working directory as current
                    tab (when midnight-commander is running)
           Product: konsole
           Version: 2.14.2
          Platform: Fedora RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: konsole-devel at kde.org
          Reporter: zsovig at yahoo.com

KDE Version: 4.14.3

Reproducible: Always

Steps to Reproduce:
1. run konsole
2. run mc in konsole
3. navigate to a directory
4. open a new tab

Actual Results:  
The new tab opens in the user's home directory.

Expected Results:  
The new tab opens in the directory where the user navigated in mc.

I investigated the problem - I think.
At the moment I am using the following versions of konsole:
konsole-4.14.3-1.fc20.x86_64.rpm
konsole-part-4.14.3-1.fc20.x86_64.rpm

So I returned back to the last working previous version, which are:
konsole-4.14.2-1.fc20.x86_64.rpm
konsole-part-4.14.2-1.fc20.x86_64.rpm

And now everything works perfectly.
So I downloaded konsole-4.14.3 and konsole-4.14.2 from here
(http://download.kde.org/stable/4.14.3/src/konsole-4.14.3.tar.xz)  and here
(http://download.kde.org/stable/4.14.2/src/konsole-4.14.2.tar.xz)
I did a directory comparison in Meld, and I found some changes in
src/Session.cpp

--- konsole-4.14.2/konsole-4.14.2/src/Session.cpp
+++ konsole-4.14.3/konsole-4.14.3/src/Session.cpp
@@ -289,15 +289,15 @@
 }
 ProcessInfo* Session::updateWorkingDirectory()
 {
-    ProcessInfo* process = getProcessInfo();
-
-    const QString currentDir = process->validCurrentDir();
+    updateSessionProcessInfo();
+
+    const QString currentDir = _sessionProcessInfo->validCurrentDir();
     if (currentDir != _currentWorkingDir) {
         _currentWorkingDir = currentDir;
         emit currentDirectoryChanged(_currentWorkingDir);
     }

-    return process;
+    return 0; // not used - for BIC in KDE 4.14.x
 }

 QList<TerminalDisplay*> Session::views() const
@@ -989,7 +989,8 @@
 QString Session::getDynamicTitle()
 {
     // update current directory from process
-    ProcessInfo* process = updateWorkingDirectory();
+    updateWorkingDirectory();
+    ProcessInfo* process = getProcessInfo();

     // format tab titles using process info
     bool ok = false;

I think the problem lies on that line where the null reference is returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the konsole-devel mailing list