[Konsole-devel] Review Request 120323: [OSX] shortcut adaptation to platform standards

[René J.V. Bertin]

> On Oct. 6, 2014, 4:01 p.m., Kurt Hindenburg wrote:
> > The Enum has been commited to 4.13 and 4.14 - I'll see about which shortcuts to change.
> 
> René J.V. Bertin wrote:
>     Do you happen to know how KDE's shortcut management system works, esp. if it's possible to export a scheme and import it elsewhere? It seems that it should be possible, also to provide multiple schemes with the install (say a legacy scheme and a new, updated scheme), but I've never got that to work (not even on Linux).

Reviving this RR now that I have gotten Konsole 15.12 to build on OS X.

It looks like nothing has changed in the code on this end. I appear not to be using any local patches for Konsole4, but yet I get the customary Command-C and Command-V for copy/paste, something I have not been able to manage with Konsole5 yet. Evidently I cannot remember if made some specific runtime shortcut configurations for Konsole4, and have never been able to figure out how these schemes are saved, can be exported etc.

I did notice that there is something fishy with the other lowlevel Qt behavioural attribute, AA_DontUseNativeMenus. Setting that attribute leads to the regular "in-window" menu in Konsole5, but leaves the toplevel menu. It the Ctrl/Meta swap attribute has a similarly ambiguous behaviour that would explain a lot ...


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120323/#review67990
-----------------------------------------------------------


On Sept. 22, 2014, 10:02 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120323/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 10:02 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole deactivates that feature. As a result, shortcuts are identical to what they are on other platforms, but not in line with what's standard on OS X.
> 
> I introduced a proxy for the standard accelerator opcode, to minimise the amount of conditional code blocks required to adapt Konsole to OS X. There is an added benefit of not using the Control key for shortcuts: `Copy` can be the usual `Command-C` instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` shortcut. I've adapted the shortcuts of a few other actions to the key combinations OS X uses for those actions.
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp 06f9321 
>   src/MainWindow.cpp 6e47939 
>   src/Session.h 9e982df 
>   src/SessionController.cpp b098d4c 
>   src/ViewManager.cpp 697ec99 
>   src/tests/PartManualTest.cpp 07489dd 
> 
> Diff: https://git.reviewboard.kde.org/r/120323/diff/
> 
> 
> Testing
> -------
> 
> on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20151229/f9dc37bd/attachment.html>