[Konsole-devel] Review Request 124590: konsole: Fix handling of high precision scroll events

[Lindsay Roberts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124590/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 7:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 5962fb25b35db2293cd195977f3e42837df6148c by Kurt Hindenburg to branch master.


Repository: konsole


Description
-------

While Konsole's main scrollbar is handled by QtScrollBar and therefore works as expected under Qt5, the other custom scroll wheel actions available do not accumulate and handle the small scroll deltas provided. This results in stuttery, uneven and unexpected responses to scrolling.

Accumulate and trigger events on thresholds. If pixel scroll values are provided, utilise them when emulating mouseup/mousedown events (by dividing by pixel font height).

Based on a previous and outstanding review (https://git.reviewboard.kde.org/r/123389/) by Xuetian Weng.


Diffs
-----

  src/CMakeLists.txt 2ff6f37 
  src/ScrollState.h PRE-CREATION 
  src/ScrollState.cpp PRE-CREATION 
  src/TerminalDisplay.h c043803 
  src/TerminalDisplay.cpp 1736aff 

Diff: https://git.reviewboard.kde.org/r/124590/diff/


Testing
-------

Tested font size zoom, emulated cursor movement, regular scroll with and without QT_DEVICE_PIXEL_RATIO=2 set on linux with a high precision trackpad. Also tested with pixel scroll data hardcoded off to ensure we still support that style (if/where Qt5 still provides it).


Thanks,

Lindsay Roberts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150816/47d93798/attachment.html>