[Konsole-devel] Review Request 123480: Replace theme preview with a pixmap what shows all the backgrounds, consisntent with the one used for SystemSettings > Colors

[Rodrigo Fernandes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123480/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 6:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and KDE Usability.


Changes
-------

Submitted with commit ea7e36667b1b74671f3860924c9cd5033043db5e by Kurt Hindenburg to branch master.


Repository: konsole


Description
-------

Simplify theme preview


Diffs
-----

  src/EditProfileDialog.cpp 62b72f3 

Diff: https://git.reviewboard.kde.org/r/123480/diff/


Testing
-------

This patch replaces the theme preview with a similar one to System Settings > Colors.

Benefits:
 Code reduction, lots of bespoke code removed
 Consistency with existing ui presentation.
 Displays the full color range as opposed to only foreground background
 
Drawbacks:
 Static pixmax might not render as well in HiDPI screens.

Any feedback is greatly appreciated. 
Please consider it for inclusion into Konsole.

Also this is my first review through RB, please mention anything I might has missed.

Regards,
 Rodrigo


File Attachments
----------------

Updated theme preview
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/5651aa87-7199-457f-b563-6c144016a06c__snapshot1.png
Foreground / Background Theme preview
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/29bd16e5-bb95-49a7-9d5f-c2eecab0f83d__snapshot2.png


Thanks,

Rodrigo Fernandes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150816/2bec0ad8/attachment.html>