[Konsole-devel] Review Request 124683: Port tests away from KDELibs4Support
Ragnar Thomsen
rthomsen6 at gmail.com
Mon Aug 10 11:06:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124683/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 1:06 p.m.)
Review request for Konsole and Kurt Hindenburg.
Changes
-------
Use QVERIFY2() and QFAIL() instead of qFatal().
Repository: konsole
Description
-------
The tests were ported away from KDELibs4Support. This consisted of KDialog->QDialog, kFatal->qFatal and linking to KF5::Parts instead of KF5::KDELibs4Support.
Diffs (updated)
-----
src/autotests/CMakeLists.txt 2a566d2
src/autotests/DBusTest.cpp ac7b257
src/autotests/PartTest.cpp 0c8e99d
Diff: https://git.reviewboard.kde.org/r/124683/diff/
Testing
-------
All tests pass.
Thanks,
Ragnar Thomsen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150810/99b7b73e/attachment.html>
More information about the konsole-devel
mailing list