[Konsole-devel] Review Request 124653: Port from K4AboutData to KAboutData

Ragnar Thomsen rthomsen6 at gmail.com
Sat Aug 8 16:09:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124653/
-----------------------------------------------------------

(Updated Aug. 8, 2015, 4:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 064d1898464bb513e5ea90329b2b150ec3c2015d by Kurt Hindenburg to branch master.


Repository: konsole


Description
-------

This patch ports from K4AboutData to KAboutData. KCmdLineArgs::init() only accepts K4AboutData as argument, so we need to supply the individual variables until KCmdLineArgs has been ported to QCommandLineParser.


Diffs
-----

  src/main.cpp 53a4b39 

Diff: https://git.reviewboard.kde.org/r/124653/diff/


Testing
-------

Konsole builds and runs. The About dialog properly shows copyright, authors, license, etc.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150808/18b0c0dd/attachment.html>


More information about the konsole-devel mailing list