[Konsole-devel] Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

[José Manuel Santamaría Lema]

> On Mayo 23, 2015, 12:23 a.m., Aleix Pol Gonzalez wrote:
> > Hm..
> > Builds here.
> > Also builds in build.kde.org... https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
> > 
> > :/
> 
> Jeremy Whiting wrote:
>     I'm not sure why, but I did test a few times before making this change. Could it be because I'm building with gcc 5.1 again?
> 
> Aleix Pol Gonzalez wrote:
>     It could be, yes. Maybe we should also get CI with gcc 5... >.<

Hi,

the build failure fixed by this patch happens only with recent gcc 5 versions, hence why you cannot allways reproduce the failure.

I can assure you that you can reproduce the build failure right now with the gcc 5.2 provided in wily/proposed and debian unstable, for instance, failing build log for unpatched konsole built in wily:
http://gpul.grupos.udc.es/logs/konsole_15.04.2-0ubuntu1+santa1.1_amd64.build

The patch in question looks right from a theorical point of view and I can also say that it fixes the build failure mentioned above, so please ship it


- José Manuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123881/#review80746
-----------------------------------------------------------


On Mayo 22, 2015, 7:49 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123881/
> -----------------------------------------------------------
> 
> (Updated Mayo 22, 2015, 7:49 p.m.)
> 
> 
> Review request for KDE Base Apps and Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Without this HistoryTest fails to link here.
> 
> 
> Diffs
> -----
> 
>   src/History.h 6314ef993a329b3a7b52b5e43aeacafaf4d896de 
> 
> Diff: https://git.reviewboard.kde.org/r/123881/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150807/d3c3cc08/attachment.html>