[Konsole-devel] Review Request 123480: Replace theme preview with a pixmap what shows all the backgrounds, consisntent with the one used for SystemSettings > Colors

[Rodrigo Fernandes]

> On April 23, 2015, 9:21 p.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > However, I think it's more important to see the actual contrast for the majority case (which is plain text on background), so seeing what green on black, or white on blue, looks like makes the theme much more discernible than a bunch of seemingly random colors. Also, you might want to add the usability group to this review request.

I can see you point.
I only placed the foreground color on the first tile row, otherwise it did feal like a random assortment of colors.
The mouse hover preview still works, so if you have something on the terminal you can immediately see how it looks, plus the names of the default themes are quite descriptive. 

Could be I just spend too much time on www.reddit.com/r/unixporn, messing with different themes :) , but I found the original preview lacking in information, I always had to click the edit button.

I'm also working on a couple of other patches that allow importing themes from other terminals files (eg:. https://wiki.archlinux.org/index.php/X_resources#Terminal_colors). Would that be of interest ?


- Rodrigo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123480/#review79408
-----------------------------------------------------------


On April 23, 2015, 9:05 p.m., Rodrigo Fernandes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123480/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 9:05 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Simplify theme preview
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 5fed35d 
>   src/EditProfileDialog.cpp 62b72f3 
>   src/EditProfileDialog.ui dc5af01 
> 
> Diff: https://git.reviewboard.kde.org/r/123480/diff/
> 
> 
> Testing
> -------
> 
> This patch replaces the theme preview with a similar one to System Settings > Colors.
> 
> Benefits:
>  Code reduction, lots of bespoke code removed
>  Consistency with existing ui presentation.
>  Displays the full color range as opposed to only foreground background
>  
> Drawbacks:
>  Static pixmax might not render as well in HiDPI screens.
> 
> Any feedback is greatly appreciated. 
> Please consider it for inclusion into Konsole.
> 
> Also this is my first review through RB, please mention anything I might has missed.
> 
> Regards,
>  Rodrigo
> 
> 
> File Attachments
> ----------------
> 
> Updated theme preview
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/5651aa87-7199-457f-b563-6c144016a06c__snapshot1.png
> 
> 
> Thanks,
> 
> Rodrigo Fernandes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150423/d6291f36/attachment-0001.html>