[Konsole-devel] Review Request 120323: [OSX] shortcut adaptation to platform standards

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120323/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X and Konsole.


Repository: konsole


Description
-------

OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole deactivates that feature. As a result, shortcuts are identical to what they are on other platforms, but not in line with what's standard on OS X.

I introduced a proxy for the standard accelerator opcode, to minimise the amount of conditional code blocks required to adapt Konsole to OS X. There is an added benefit of not using the Control key for shortcuts: `Copy` can be the usual `Command-C` instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` shortcut. I've adapted the shortcuts of a few other actions to the key combinations OS X uses for those actions.


Diffs
-----

  src/Application.cpp 06f9321 
  src/MainWindow.cpp 6e47939 
  src/Session.h 9e982df 
  src/SessionController.cpp b098d4c 
  src/ViewManager.cpp 697ec99 
  src/tests/PartManualTest.cpp 07489dd 

Diff: https://git.reviewboard.kde.org/r/120323/diff/


Testing
-------

on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140922/30ffc321/attachment.html>