[Konsole-devel] Review Request 119914: Add feature to copy HTML from terminal

Kurt Hindenburg kurt.hindenburg at gmail.com
Sun Sep 14 13:12:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119914/#review66462
-----------------------------------------------------------


Thanks - overall it looks OK - some minor nitpicks but I'll take care of them.  Since this is a feature it will go into master/KF5 and not KDE 4.x

- Kurt Hindenburg


On Sept. 14, 2014, 12:08 p.m., Anonymous Koavohv wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119914/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 12:08 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This patch adds a support for copying HTML formatted text from terminal. It is quite short, as Konsole already has code to export history to HTML.
> It shouldn't break anything.
> 
> 
> Diffs
> -----
> 
>   src/Screen.h 820c7e1 
>   src/Screen.cpp 6692484 
>   src/ScreenWindow.h 11d599b 
>   src/ScreenWindow.cpp 2c873dc 
>   src/TerminalDisplay.cpp c469b25 
> 
> Diff: https://git.reviewboard.kde.org/r/119914/diff/
> 
> 
> Testing
> -------
> 
> https://bugsfiles.kde.org/attachment.cgi?id=88388
> 
> 
> Thanks,
> 
> Anonymous Koavohv
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140914/5079c23e/attachment.html>


More information about the konsole-devel mailing list