[Konsole-devel] Review Request 120001: Make konsole -e "man ls" work as expected, while also coping with paths with spaces in

[Mark Raymond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120001/#review66306
-----------------------------------------------------------


Hello - how long might it take for this review request to be looked at? I'm in no hurry - just interested to know :) Thanks!

- Mark Raymond


On Aug. 30, 2014, 11:15 a.m., Mark Raymond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120001/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 11:15 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> A couple of years ago, [bug 295648](https://bugs.kde.org/show_bug.cgi?id=295648) was fixed, introducing support for `konsole -e "man ls"` in [commit aa75fc8f](https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/aa75fc8fee7e55e0c78640fcbed0bf0627ba7971). However it introduced [bug 308553](https://bugs.kde.org/show_bug.cgi?id=308553), which meant that `konsole -e "path with spaces in.sh"` no longer worked, and so the fix was reverted in [commit 48b5575c](https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/48b5575c174fb4edb6d3388d7a22dec148dea8cb).
> 
> This patch fixes [bug 295648](https://bugs.kde.org/show_bug.cgi?id=295648) without reintroducing [bug 308553](https://bugs.kde.org/show_bug.cgi?id=308553) by checking whether the first parameter exists before interpreting using ShellCommand.
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp 0c4ae08a19c906b3939f3e77c2157f99c1d13fef 
> 
> Diff: https://git.reviewboard.kde.org/r/120001/diff/
> 
> 
> Testing
> -------
> 
> konsole -e man ls
> konsole -e "man ls"
> 
> konsole -e /bin/sh ./geany_run_script.sh
> konsole -e "/bin/sh ./geany_run_script.sh"
> 
> konsole -e "/home/mark/script with spaces.sh"
> konsole -e /home/mark/script\ with\ spaces.sh
> 
> 
> Thanks,
> 
> Mark Raymond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140912/f40d7ea8/attachment.html>