[Konsole-devel] Review Request 120763: Add new signal : backgroundProcessPwdChanged

[Kurt Hindenburg]

> On Oct. 23, 2014, 9:58 p.m., Frank Reininghaus wrote:
> > Cool, thanks for looking into this! I think that many users will appreciate any improvements in this area.
> > 
> > I'm just wondering, do we really need two different signals which do quite similar things? I guess the 'old' signal would not be used any more, so maybe one could simply change the behavior of currentDirectoryChanged, such that it does what your new signal would do, and not introduce a new signal at all?
> 
> Arjun AK wrote:
>     The new signal is only emitted when the PWD of the shell changes and not when it is changed by the running 'foreground' process. Wouldn't changing the behaviour break other apps?
> 
> Frank Reininghaus wrote:
>     There are no other apps that use this signal. At least http://lxr.kde.org/ident?_i=currentDirectoryChanged&_remember=1 does not show any. Moreover, even if there were other apps, I don't think that there is a common use case where staying informed about temporary directory changes caused by "man ls", "git status", etc., is what the user wants.
> 
> Kurt Hindenburg wrote:
>     If we want this in KDE 4.14.x, we can add signals but not remove them AFAIK.
> 
> Arjun AK wrote:
>     ok, master then?
> 
> Kurt Hindenburg wrote:
>     I wouldn't mind trying to get this in KDE 4.14.x and then we can do add it in master (which is frameworks based).
> 
> Arjun AK wrote:
>     >we can add signals but not remove them AFAIK.
>     
>     We aren't removing the signal, but just changing the condition under which it gets emitted. Since dolphin is the only KDE application that uses it and since doing so would help fix a bug, can't we push this to 4.14?

This would change signature and isn't BIC - not sure about going in 4.14.3 (tagged on Nov 6th).


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120763/#review69053
-----------------------------------------------------------


On Oct. 27, 2014, 1:19 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120763/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 1:19 p.m.)
> 
> 
> Review request for Konsole, Emmanuel Pescosta and Frank Reininghaus.
> 
> 
> Bugs: 305085
>     http://bugs.kde.org/show_bug.cgi?id=305085
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Listening to the currentDirectoryChanged() can cause dolphin to act weird when you have programs running on the konsole part. for instance:
> 
> 1) `$ man ls` -> Dolphin temporarily switches to the manpages directory
> 2) `$ man ls`. Now quickly press q and CTRL D, you get stuck in the manpages directory.
> 3) `(cd /;sleep .5; cd /tmp; sleep .5)`
> 4) When you have scripts running(like kdesrc-build), dolphin keeps on changing the directories
> 
> By adding a new signal, which is only emitted when the PWD of the shell is changed, these [bugs](https://bugs.kde.org/show_bug.cgi?id=305085) can be fixed.
> 
> 
> Diffs
> -----
> 
>   src/Session.h 6cd283a 
>   src/Session.cpp cf70c09 
> 
> Diff: https://git.reviewboard.kde.org/r/120763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141028/f32ace77/attachment.html>