[Konsole-devel] Review Request 120693: fix 337241 - Konsole hides tabs when moving them using keyboard

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120693/#review68869
-----------------------------------------------------------



src/ViewContainer.cpp
<https://git.reviewboard.kde.org/r/120693/#comment48158>

    Does this comment still apply, does it need to be moved or removed? There are now two blank lines after this comment, at least RB makes me believe there are.


- Christoph Feck


On Oct. 21, 2014, 5:47 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120693/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 5:47 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 337241
>     http://bugs.kde.org/show_bug.cgi?id=337241
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> We dont need to explicitly remove the tab from the tabbar while the view is being moved, it will be automatically removed when the widget is removed from the stacked widget
> 
> 
> Diffs
> -----
> 
>   src/ViewContainer.cpp d425e0e 
> 
> Diff: https://git.reviewboard.kde.org/r/120693/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141022/f9714dfb/attachment.html>