[Konsole-devel] Review Request 120560: port away from kde_file

Michal Humpula michal.humpula at hudrydum.cz
Sat Oct 11 18:49:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120560/
-----------------------------------------------------------

Review request for Konsole.


Repository: konsole


Description
-------

* It's possible to use QFile or QFileInfo in most cases.
* Since there already is a `#ifdef` for `OS_MAC`, I've used native unix stat for MacProcessInfo.
* The `tcgetpgrp` seems to be available everywhere, but the Windows, so wrapping to #ifdef.


Diffs
-----

  src/Part.cpp 9923cd4 
  src/ProcessInfo.cpp f59c37c 
  src/Pty.cpp c61d883 

Diff: https://git.reviewboard.kde.org/r/120560/diff/


Testing
-------

compiles


Thanks,

Michal Humpula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141011/c5c83ee6/attachment.html>


More information about the konsole-devel mailing list