[Konsole-devel] Review Request 120498: porting from KStandardDirs to QStandardPaths

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120498/#review68127
-----------------------------------------------------------



src/ColorSchemeManager.cpp
<https://git.reviewboard.kde.org/r/120498/#comment47460>

    QDir().mkpath(dir); seems better.



src/Session.cpp
<https://git.reviewboard.kde.org/r/120498/#comment47461>

    you can add "const QString..."


- Laurent Montel


On oct. 5, 2014, 10:19 matin, Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120498/
> -----------------------------------------------------------
> 
> (Updated oct. 5, 2014, 10:19 matin)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> ported according to https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp c67dca5 
>   src/BookmarkHandler.cpp eed2d7c 
>   src/ColorSchemeManager.cpp d4dcb0d 
>   src/History.cpp 67f07c9 
>   src/KeyboardTranslatorManager.cpp dc891e9 
>   src/ManageProfilesDialog.cpp 29d25a6 
>   src/ProfileManager.cpp 1ab3fce 
>   src/ProfileReader.cpp 053f3e1 
>   src/ProfileWriter.cpp 143787b 
>   src/Session.cpp 04fea2d 
>   src/SessionController.cpp faf0eb2 
> 
> Diff: https://git.reviewboard.kde.org/r/120498/diff/
> 
> 
> Testing
> -------
> 
> manual testing: loading, deleting profiles
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141009/6724bf1d/attachment.html>