[Konsole-devel] Review Request 120493: port from KIcon to QIcon

Laurent Montel montel at kde.org
Thu Oct 9 10:39:15 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120493/#review68126
-----------------------------------------------------------



src/SessionListModel.cpp
<https://git.reviewboard.kde.org/r/120493/#comment47459>

    not QIcon::fromTheme ?


- Laurent Montel


On oct. 4, 2014, 10:04 après-midi, Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120493/
> -----------------------------------------------------------
> 
> (Updated oct. 4, 2014, 10:04 après-midi)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> port from KIcon to QIcon
> 
> 
> Diffs
> -----
> 
>   src/ColorSchemeEditor.cpp ad7438a 
>   src/EditProfileDialog.cpp 0375110 
>   src/IncrementalSearchBar.cpp 965d473 
>   src/KeyBindingEditor.cpp 9f2bc7a 
>   src/MainWindow.cpp c9e22e9 
>   src/ManageProfilesDialog.cpp 29d25a6 
>   src/ProfileList.cpp 4c92b0d 
>   src/SessionController.h 4079a14 
>   src/SessionController.cpp faf0eb2 
>   src/SessionListModel.cpp 58854aa 
>   src/ViewContainer.cpp d425e0e 
>   src/ViewContainerTabBar.cpp 617a366 
>   src/ViewManager.cpp 359aa06 
> 
> Diff: https://git.reviewboard.kde.org/r/120493/diff/
> 
> 
> Testing
> -------
> 
> compilation and manual icon review
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141009/ff3f7dc4/attachment.html>


More information about the konsole-devel mailing list