[Konsole-devel] Review Request 120323: [OSX] shortcut adaptation to platform standards

[René J.V. Bertin]

> On Oct. 4, 2014, 4:35 p.m., Kurt Hindenburg wrote:
> > src/MainWindow.cpp, line 197
> > <https://git.reviewboard.kde.org/r/120323/diff/1/?file=314597#file314597line197>
> >
> >     If we're going to try for the Mac way, shouldn't we remove the SHIFT?
> 
> René J.V. Bertin wrote:
>     I don't see why. On Linux you're not using the standard accel. key + B, why would we on OS X? There's no "standard" shortcut for "Add Bookmark" that I know of, so Command-Shift-B is just as good a default as Command-B.
> 
> Kurt Hindenburg wrote:
>     Sorry I didn't explain myself - I was just using the Bookmark as an example - I was thinking of all the others as well - why should copy/paste/new tab have shift?
>     THe reason we had to add SHIFT in the beginning was to past the non-SHIFT keystrokes to the terminal.

You'd still need the SHIFT moderator to avoid a conflict with terminal/shell control characters. There may be a number (^B, ^N) that aren't used (anymore), but the most often used menu actions have shortcuts (^C and ^V) that still are used. I don't see a way around that.

Besides, you probably shouldn't change any less-obscure shortcuts too lightly on platforms where konsole has been the usual terminal emulator since a long time. Konsole doesn't have that history on OS X, so there it's possible to rethink a certain number of shortcuts, and take profit of the fact that the shortcut key is not the Control key.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120323/#review67922
-----------------------------------------------------------


On Sept. 22, 2014, 10:02 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120323/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 10:02 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole deactivates that feature. As a result, shortcuts are identical to what they are on other platforms, but not in line with what's standard on OS X.
> 
> I introduced a proxy for the standard accelerator opcode, to minimise the amount of conditional code blocks required to adapt Konsole to OS X. There is an added benefit of not using the Control key for shortcuts: `Copy` can be the usual `Command-C` instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` shortcut. I've adapted the shortcuts of a few other actions to the key combinations OS X uses for those actions.
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp 06f9321 
>   src/MainWindow.cpp 6e47939 
>   src/Session.h 9e982df 
>   src/SessionController.cpp b098d4c 
>   src/ViewManager.cpp 697ec99 
>   src/tests/PartManualTest.cpp 07489dd 
> 
> Diff: https://git.reviewboard.kde.org/r/120323/diff/
> 
> 
> Testing
> -------
> 
> on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141006/45a23294/attachment-0001.html>