[Konsole-devel] Review Request 120323: [OSX] shortcut adaptation to platform standards

[Kurt Hindenburg]

> On Oct. 4, 2014, 2:16 p.m., Kurt Hindenburg wrote:
> > src/ViewManager.cpp, line 248
> > <https://git.reviewboard.kde.org/r/120323/diff/1/?file=314600#file314600line248>
> >
> >     AFAIK, all apple keyboards have the arrows - I prefer using arrows.  Also, doesn't this conflict w/ line 191 shrink active view?
> 
> René J.V. Bertin wrote:
>     You're right about the conflict (override, I presume?). I'll see what the action actually does, and then if I can come up with a "logical" shortcut.
>     But: Command-Shift-[ and Command-Shift-] are the standard shortcuts for these actions on OS X. Command-Shift-Left and Command-Shift-Right are the (even more) standard shortcuts for selecting to the beginning and end of line, respectively. That's something so historical that I really don't want to change it.

Well if you keep [], we'll need to have arrows as the 2nd shortcuts.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120323/#review67920
-----------------------------------------------------------


On Sept. 22, 2014, 8:02 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120323/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 8:02 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole deactivates that feature. As a result, shortcuts are identical to what they are on other platforms, but not in line with what's standard on OS X.
> 
> I introduced a proxy for the standard accelerator opcode, to minimise the amount of conditional code blocks required to adapt Konsole to OS X. There is an added benefit of not using the Control key for shortcuts: `Copy` can be the usual `Command-C` instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` shortcut. I've adapted the shortcuts of a few other actions to the key combinations OS X uses for those actions.
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp 06f9321 
>   src/MainWindow.cpp 6e47939 
>   src/Session.h 9e982df 
>   src/SessionController.cpp b098d4c 
>   src/ViewManager.cpp 697ec99 
>   src/tests/PartManualTest.cpp 07489dd 
> 
> Diff: https://git.reviewboard.kde.org/r/120323/diff/
> 
> 
> Testing
> -------
> 
> on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141005/756dddce/attachment.html>