[Konsole-devel] Review Request 109571: Add option to close tab on middle (wheel) mouse button click

[Helmy m-]

> On Feb. 13, 2014, 3:32 p.m., Kurt Hindenburg wrote:
> > Thanks for the patch; however, I don't think this is worth adding.  The user can right-click->close tab.

Please refer to Bug 191751 https://bugs.kde.org/show_bug.cgi?id=191751  for the full discussion that lead to this patch, the option is disabled by default and it is there for the users who want to have this feature


- Helmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109571/#review49713
-----------------------------------------------------------


On March 18, 2013, 9:34 p.m., Oleksandr Sochka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109571/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 9:34 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> There is no action assigned on middle mouse button right now
> and this patch adds an option to Settings->Configure->Taskbar which enables 
> closing a tab like in browsers/different editors using wheel click.
> 
> Option is disabled by default.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b297883 
>   src/MainWindow.cpp 0ba82f0 
>   src/ViewContainer.h d5bdf73 
>   src/ViewContainer.cpp 63c187d 
>   src/ViewManager.h f039a27 
>   src/ViewManager.cpp 8a902d0 
>   src/settings/TabBarSettings.ui b9ace21 
>   src/settings/konsole.kcfg b850d9a 
> 
> Diff: https://git.reviewboard.kde.org/r/109571/diff/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Oleksandr Sochka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140526/d4a7afa1/attachment.html>