[Konsole-devel] Review Request 119004: Fix crash caused by dereferencing a deleted submenu

[Arjun Ak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119004/
-----------------------------------------------------------

(Updated July 2, 2014, 2:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole.


Repository: konsole


Description
-------

Submenu of new "newTabMenuAction" is dereferenced in multiple places without first checking whether it is null or not which can lead to a crash, especially since we delete it (https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/c4f7f512f3bbd8235947defc8f3f848244d7ca1b/entry/src/MainWindow.cpp#L422) if there is only one profile to be shown.


Diffs
-----

  src/MainWindow.cpp 86d04de 

Diff: https://git.reviewboard.kde.org/r/119004/diff/


Testing
-------


Thanks,

Arjun Ak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140702/16dcb718/attachment.html>