[Konsole-devel] Review Request 111441: Fix many selection related bugs including selecting invisible region on double/triple click

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111441/
-----------------------------------------------------------

(Updated Jan. 12, 2014, 6:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Bugs: 319260
    http://bugs.kde.org/show_bug.cgi?id=319260


Repository: konsole


Description
-------

This patch fixes many bugs related to selection in konsole including:
1, bug#319260, double/triple click can only select text within visible region.
2, triple click in SelectForwardsFromCursor mode will start the selection from the corresponding position in the first visible line (line on the screen) of the current "logical" line.
3, excluding "@" in word selection mode is not working if the end of the selection is at the left (after line wrap) of the beginning.
4, excluding "@" in word selection mode is not working as soon as there is a mouse moving event, even if only by a tiny amount.


Diffs
-----

  src/TerminalDisplay.h 100ffcc 
  src/TerminalDisplay.cpp acfddc1 

Diff: https://git.reviewboard.kde.org/r/111441/diff/


Testing
-------

Compiled and tested for a lot of cases.


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140112/69247010/attachment.html>