[Konsole-devel] Review Request 115628: Add profile settings for columns/rows

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115628/#review49839
-----------------------------------------------------------


This review has been submitted with commit 931d64df81dd07548a2abecfde65780036ff1fa1 by Kurt Hindenburg to branch master.

- Commit Hook


On Feb. 11, 2014, 3:49 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115628/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 3:49 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 152385
>     http://bugs.kde.org/show_bug.cgi?id=152385
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Follow up to https://git.reviewboard.kde.org/r/103952/
> 
> Note this is not finished code (gui needs more work, etc) - I need to test and see if it actually works and if there are any issues still.
> 
> If anyone wants to review/commnet and/or test, please do so.
> 
> ==
> Remove profile setting  - save geometry size on exit
> Add Konsole setting - save geometry size on exit (nullifies profile settings)
> Add Profile terminal col/row settings
> If "save geometry", use kmainwindow settings,  ignore profile col/row
> If not "save geometry", remove kmainwindow settings, use profile col/row
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 97adb93b7540fa971bb450bbabf3e5381a6a53c0 
>   src/EditProfileDialog.cpp d43a89666693dfa767e21049df85ff86fded02c4 
>   src/EditProfileDialog.ui 82298cfe0f554188f2983afe23e8c23bceeae3f6 
>   src/MainWindow.h 33e0fda25612f5a27be55de0af61fb37c61501b1 
>   src/MainWindow.cpp 6eccdf818c819432ab361a2565793dcfeef8e5b2 
>   src/Profile.h 596f78acc2a570a904203a646f74b4f957d080be 
>   src/Profile.cpp 14946ce69000eef00b03864e4610c6775597a51d 
>   src/ViewManager.h 2a7f3483fcdbc1397b47df65ad8317df2215b33b 
>   src/ViewManager.cpp 0b43bb88aee914a3d82965eb6349dc4938368704 
>   src/settings/GeneralSettings.cpp 4a3786268fee953bbaab1b6ec300d6a607242bed 
>   src/settings/GeneralSettings.ui 20b7a29d8855128a862b8b339055f2d9f30c61d0 
>   src/settings/konsole.kcfg dbe5ef55187dd226faa56c6c7c081c606e341158 
> 
> Diff: https://git.reviewboard.kde.org/r/115628/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140215/b41bab6d/attachment.html>