[Konsole-devel] Review Request 107816: Refactor the code of ssh command parsing

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107816/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 3:49 p.m.)


Status
------

This change has been discarded.


Review request for Konsole and Kurt Hindenburg.


Repository: konsole


Description
-------

The initial motivation is to make it easier for konsole to support other ssh-like commands, like mosh (bug 308102).  In short, this refactoring has done three things:

  1. Move the logic into one separate and static method, which means it can be easily tested and substituted.
  2. Add some simple testcases to catch potential regressions.
  3. Refactor the internal logic to make it more readable.

The code now lives in the adaptee/ssh-parse-refactor  branch .


Diffs
-----


Diff: https://git.reviewboard.kde.org/r/107816/diff/


Testing
-------

No regression catched in daily usage and the testcases.

Kurt has also done some basic testing using the new code (many thanks). 


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140213/342b7b62/attachment-0001.html>