[Konsole-devel] Review Request 115628: Allow profile settings for columns and rows

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115628/
-----------------------------------------------------------

Review request for Konsole.


Bugs: 152385
    http://bugs.kde.org/show_bug.cgi?id=152385


Repository: konsole


Description
-------

Follow up to https://git.reviewboard.kde.org/r/103952/

Note this is not finished code (gui needs more work, etc) - I need to test and see if it actually works and if there are any issues still.

If anyone wants to review/commnet and/or test, please do so.

==
Remove profile setting  - save geometry size on exit
Add Konsole setting - save geometry size on exit (nullifies profile settings)
Add Profile terminal col/row settings
If "save geometry", use kmainwindow settings,  ignore profile col/row
If not "save geometry", remove kmainwindow settings, use profile col/row


Diffs
-----

  src/EditProfileDialog.h 97adb93 
  src/EditProfileDialog.cpp d43a896 
  src/EditProfileDialog.ui 82298cf 
  src/MainWindow.h 33e0fda 
  src/MainWindow.cpp 6eccdf8 
  src/Profile.h 596f78a 
  src/Profile.cpp 14946ce 
  src/ViewManager.h 2a7f348 
  src/ViewManager.cpp 0b43bb8 
  src/settings/GeneralSettings.cpp 4a37862 
  src/settings/GeneralSettings.ui 20b7a29 
  src/settings/konsole.kcfg dbe5ef5 

Diff: https://git.reviewboard.kde.org/r/115628/diff/


Testing
-------


Thanks,

Kurt Hindenburg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140210/a0918fc6/attachment.html>