[Konsole-devel] Review Request 119908: Avoid linking to unused libraries

[Bernd Steinhauser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119908/
-----------------------------------------------------------

Review request for Konsole.


Repository: konsole


Description
-------

konsole uses the variable ${X11_LIBRARIES} for linking, which will result in linking against libX11, libSM, libICE and libXext.
In the source code, I could only find usages of libX11, so I propose to use ${X11_X11_LIB} instead of ${X11_LIBRARIES}. However, I'm not familiar with konsole's code and I'm not a c++ coder, so it could be that I overlooked some usage of the other libraries.


Diffs
-----

  src/CMakeLists.txt 551a148 

Diff: https://git.reviewboard.kde.org/r/119908/diff/


Testing
-------

konsole with current HEAD of the frameworks branch was built with the patch applied. It compiled, linked and ran without any issues, that could be related to the applied diff.


Thanks,

Bernd Steinhauser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140822/4f9f7d0a/attachment.html>