[Konsole-devel] Review Request 117482: Convert to Qt5 signal slot syntax

[Kurt Hindenburg]

> On April 12, 2014, 1:23 a.m., Kurt Hindenburg wrote:
> > Ship It!

I see from review 117478, there might be concerns about these changes - I have a good diff I can commit when it is decided all these changes are good.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117482/#review55481
-----------------------------------------------------------


On April 10, 2014, 2:23 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117482/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 2:23 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Convert to Qt5 signal slot syntax
> 
> This was done automatically with some minor adaptions using my clang based conversion tool
> (https://github.com/a-richardson/convert2qt5signalslot)
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp c14edb90c93bb41af0033c7ddff5919a13830d7d 
>   src/ColorSchemeEditor.cpp 9f029ab630dc9584e4d6cd72daa1e6b3abb1dd22 
>   src/CopyInputDialog.cpp 619307b98a6a52c0611ee3b101cd9c9a60308171 
>   src/EditProfileDialog.cpp f52d6dc4b4b6560391567fa63ad3fc7b5182834e 
>   src/Emulation.h 52a34b4eeaee9eb71389f2987c5e84bf005d8bc2 
>   src/Emulation.cpp 4363f571cde5d21c53c2d3b60907c5e78223c824 
>   src/Filter.h cbcc8e22d073ab8e435dba07a5488e797d0cf4f6 
>   src/Filter.cpp bb695fb3d0741c94eb3d3529249a33766f0583eb 
>   src/HistorySizeWidget.cpp f45608a322f10981adba9b677d939a734ba7efd4 
>   src/IncrementalSearchBar.cpp 133c84438aef41b014ccfe128628f3a6f31084b1 
>   src/KeyBindingEditor.cpp c22bb4fc6ef31ffb5b429b1c7a8f9293201b711b 
>   src/MainWindow.cpp ea0b9796bee63674f1704f357ca010cbd14041f9 
>   src/ManageProfilesDialog.cpp a2887b611194aaed86815fb160a17e80dc96989f 
>   src/Part.cpp 69f700a9e6ae316ba9cc621f012d3e74563f8f64 
>   src/ProfileList.cpp a393371c9feffcacbeb8cfb72571219626d55545 
>   src/Pty.h 73b453610f51fad6f82902b58b90d1d180f9f303 
>   src/Pty.cpp dcff7e5b411e4b7528d8d771a45ff40ea71a096c 
>   src/RenameTabWidget.cpp 873ebcf8b37ee7844de173435687478b7f03e4b4 
>   src/Session.h 9e982df6dbe16e71c56c6cc9c98b93f04205d846 
>   src/Session.cpp cf0fc4d8edda0956a2f96499cb08fc08ba2a7cc6 
>   src/SessionController.cpp 5cd69ec364e1c8ec8a7b6406e4e0d8ca78385f03 
>   src/SessionListModel.cpp 33af851f90dfa0494f7d6051203d2d91f79cc0da 
>   src/SessionManager.cpp 1b80b75002516c699fd57b57625f93c7a0b22cfe 
>   src/TabTitleFormatButton.cpp 7b85ffee02f59b6fa6c0e00e4a463811da97cd0d 
>   src/TerminalDisplay.h f0699e92b60b210d0d34d48aecb99b6405f8483a 
>   src/TerminalDisplay.cpp e67b449a161ab4c5819749d22f8ff1f1b89eae47 
>   src/ViewContainer.cpp 4acc0e3005e9d6a21527c2a48b41700cbd28df02 
>   src/ViewManager.cpp 6485586bc6bdabde94a0b81a9463855a3dc744ec 
>   src/ViewSplitter.cpp ea043738d15b73b63d3e44b390d1e10271339415 
>   src/Vt102Emulation.h 8d678e00b28b2d055e0f324367e0990a7c04e925 
>   src/Vt102Emulation.cpp 33df23bbf346cd6ddbbe3dac39898d56944ea941 
>   src/ZModemDialog.cpp e5e7ce93353175bc8f2f01bb3a3240f3d51a4e74 
>   src/settings/GeneralSettings.cpp 160a87a916e6fed3b56ea97ec9515e1485244763 
>   src/tests/PartManualTest.cpp 957877b85dffb455247f90d52f925f6b47c816e0 
> 
> Diff: https://git.reviewboard.kde.org/r/117482/diff/
> 
> 
> Testing
> -------
> 
> Compiles and starts (might also fix some bad connections)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140421/44285869/attachment.html>