[Konsole-devel] Review Request 112498: Check what processes are running when asking for confirmation for closing window

[Martin Tobias Holmedahl Sandsmark]

> On Sept. 14, 2013, 2:37 p.m., Kurt Hindenburg wrote:
> > Thanks - the List box looks too big and ugly - let's go back to the previous inline.
> > 
> > Do you have commit access?

well, with enough open processes and small enough screen the dialog will probably grow off screen. also, this kind of dialog is the same as in kate and everywhere else, so I think it makes sense.

and yes, I have commit access.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112498/#review40022
-----------------------------------------------------------


On Sept. 13, 2013, 6:39 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112498/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 6:39 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> Instead of just counting the number of open sessions check what processes are actually running in them.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 285d634 
>   src/ViewManager.h fac2823 
> 
> Diff: http://git.reviewboard.kde.org/r/112498/diff/
> 
> 
> Testing
> -------
> 
> Tested with zero, one and two processes running.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130915/efd4c827/attachment.html>