[Konsole-devel] Review Request 110536: [ColorSchemeEditor improvements v2](part6/6): Hide EditProfileDialog when ColorSchemeEditor is visible

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110536/#review40025
-----------------------------------------------------------


This only works from Edit Current Profile; from Manage Profiles->Edit Profile the ColorSchemeEditor is never displayed.

I'm reverting this commit for now.

- Kurt Hindenburg


On May 23, 2013, 12:57 p.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110536/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 12:57 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The last one of the serie.
> 
> Hide EditProfileDialog when opening ColorSchemeEditor.
> 
> I am not sure it is the usual way of doing it in KDE, but I think in this case it is better if the parent dialog is hidden when the user is tweaking a theme : I'm using it a lot, and I like to be able to get an idea of the result in the terminal when I change some color (is it looking nice ? Are contrast Okay ?...).
> 
> Before this patch the user gets up to 4 windows stacked one over the other : konsole main window / EditProfileDialog / ColorSchemeEditor / KColorDialog (when changing one color). Hiding EditProfileDialog makes it less crowded and easier to see the result in the terminal.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.cpp 98ae2e7 
> 
> Diff: http://git.reviewboard.kde.org/r/110536/diff/
> 
> 
> Testing
> -------
> 
> Compile / run / used for several days
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130914/d8e0af28/attachment.html>