[Konsole-devel] Review Request 112498: Check what processes are running when asking for confirmation for closing window

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112498/#review39465
-----------------------------------------------------------


Don't worry about the Mac part, I'll fix it

Otherwise it looks OK.  I wonder if the process names should be combined/unique.  Say you have 3 vi running: should it say (vi, vi, vi) or just (vi)?

- Kurt Hindenburg


On Sept. 4, 2013, 10:24 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112498/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 10:24 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> Instead of just counting the number of open sessions check what processes are actually running in them.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 285d634 
> 
> Diff: http://git.reviewboard.kde.org/r/112498/diff/
> 
> 
> Testing
> -------
> 
> Tested with zero, one and two processes running.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130906/5a8fc17d/attachment.html>