[Konsole-devel] Review Request 112507: Fix for “ HTML export has too many closing span tags in it”

[Martin Ueding]

> On Sept. 4, 2013, 1:03 p.m., Kurt Hindenburg wrote:
> > Thanks it looks good.  On another topic, I wonder if it should be valid HTML w/ doctype/head/body/etc.
> 
> Kurt Hindenburg wrote:
>     actually looking at the code more closely, can the " = false" just be put in closeSpan()?

Valid HTML would have the advantage that one could use a set of CSS declarations and use classes instead of literal styles in the document. Pygments (syntax highlighter) does the same thing.

The `= false` should not be put into HTMLDecoder::closeSpan(). That method is called by HTMLDecoder::end(). And there, it is just used to close the final *outter* span. I could add another method, HTMLDecode::closeInnerSpan() to do this, but that might be unneeded for two calls.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112507/#review39346
-----------------------------------------------------------


On Sept. 4, 2013, 10:37 a.m., Martin Ueding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112507/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 10:37 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This fixes the linked bug.
> 
> 
> This addresses bug 324476.
>     http://bugs.kde.org/show_bug.cgi?id=324476
> 
> 
> Diffs
> -----
> 
>   src/TerminalCharacterDecoder.cpp 0615d5d 
> 
> Diff: http://git.reviewboard.kde.org/r/112507/diff/
> 
> 
> Testing
> -------
> 
> I built and tested it with three sessions, the exported HTML looked right.
> 
> 
> Thanks,
> 
> Martin Ueding
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130904/c49da3b0/attachment-0001.html>