[Konsole-devel] Review Request 112983: A new prototype feature for Konsole: Scroll Marks

[Phillip Taylor]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112983/#review42878
-----------------------------------------------------------


Hi Guys, original author here. I've been actively using this at the moment and I have one or two refinements to make. The main issue is that it's great when it has to scroll, but when you hit enter consecutively and then scroll up and down it doesn't quite move as you'd expect which is a bit jarring. I'm going to continue to play and experiment a little bit, perhaps using highlighted lines like the search feature does. Keep looking for whatever seems to feel most natural, I don't think I'm quite there yet.

I'm actually on holiday for the next three weeks and away from a computer but I wanted to thank you for taking a look at this and re-stimulating some interest in it. I can assure you when I'm back in December that I'll be taking on the code review feedback and actively looking to polish this to KDE standards.

Thanks again guys

- Phillip Taylor


On Oct. 8, 2013, 12:05 a.m., Phillip Taylor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112983/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 12:05 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> I'm not a KDE developer or QT person myself, but I had an "itch to scratch" as we say. A desire to add a new feature to Konsole. The feature is called 'Scroll Marks' and in a nutshell it allows you to mark line numbers in Konsole's output and then using next and previous menu options, quickly scroll to those points.
> 
> It basically makes scrolling up and down easier because you can jump through your output history even more quickly.
> 
> I went a step further and made these scroll marks automatically get created when the control character 6 is seen. This means that you can put 'echo -en \\06' in your PS1 prompt and Ctrl+Up and Ctrl+Down immediately scroll you up and down between all the commands you've executed. So when that cat or grep statement surprises you with a massive amount of output, it's just a key combination away to go up past it again. And no annoyance of manually scrolling too far in each direction.
> 
> Since it works using a simple control character approach, it works recursively across ssh, screen and older systems really well. If you're a dev you can put it in your warn statements so when tailing logs it's easier to navigate to where you want to. If you work with grep/cat a lot, a simple sed command can make finding stuff much quicker and simpler.
> 
> The feature works quite well and I think a lot of people would like it. I hope some of you will take the time to try it out!
> 
> I'm casually requesting its integration into Konsole depending on how others feel, but if you don't like it, I enjoyed writing it and will still probably continue to use it myself.
> 
> I would also appreciate a code review of the work so that even if you don't want this feature, I don't introduce bugs into my own forks.
> 
> 
> Diffs
> -----
> 
>   desktop/sessionui.rc 67d89ae 
>   desktop/konsoleui.rc 1dd4f69 
>   src/Emulation.h 92a0ea7 
>   src/Emulation.cpp 02ed4be 
>   src/Session.h 9e982df 
>   src/Session.cpp e27bf78 
>   src/SessionController.h 2ff7910 
>   src/SessionController.cpp 62c1d0b 
>   src/Vt102Emulation.cpp 0b6d2ed 
> 
> Diff: http://git.reviewboard.kde.org/r/112983/diff/
> 
> 
> Testing
> -------
> 
> I'm not really sure how to do this. Some pointers would be very much appreciated. The feature does work though. :-)
> 
> 
> Thanks,
> 
> Phillip Taylor
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20131102/be5a9708/attachment.html>