[Konsole-devel] Review Request 112983: A new prototype feature for Konsole: Scroll Marks

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112983/#review42753
-----------------------------------------------------------


I have a few more comments below. Other than that it still seems like a cool feature, could one of the konsole maintainers comment on this before it bitrots? ;)


src/Emulation.cpp
<http://git.reviewboard.kde.org/r/112983/#comment30907>

    As I mentioned before this seems rather arbitrary to me. If anything, I would use 0x1D "GROUP SEPARATOR" as the default, that seems most thematic. The better, since more discoverable alternative would be to have a configuration option somewhere about which character to use. However I'm not sure if the konsole maintainers would accept an additional option...



src/SessionController.h
<http://git.reviewboard.kde.org/r/112983/#comment30908>

    wrong indentation



src/SessionController.cpp
<http://git.reviewboard.kde.org/r/112983/#comment30909>

    Can you use connect() with the Qt::UniqueConnection option instead?



src/SessionController.cpp
<http://git.reviewboard.kde.org/r/112983/#comment30910>

    It feels a bit untidy to have this code effectively twice with only slight changes but I don't see an obvious way to improve it :(


- Sven Brauch


On Oct. 8, 2013, 12:05 a.m., Phillip Taylor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112983/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 12:05 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> I'm not a KDE developer or QT person myself, but I had an "itch to scratch" as we say. A desire to add a new feature to Konsole. The feature is called 'Scroll Marks' and in a nutshell it allows you to mark line numbers in Konsole's output and then using next and previous menu options, quickly scroll to those points.
> 
> It basically makes scrolling up and down easier because you can jump through your output history even more quickly.
> 
> I went a step further and made these scroll marks automatically get created when the control character 6 is seen. This means that you can put 'echo -en \\06' in your PS1 prompt and Ctrl+Up and Ctrl+Down immediately scroll you up and down between all the commands you've executed. So when that cat or grep statement surprises you with a massive amount of output, it's just a key combination away to go up past it again. And no annoyance of manually scrolling too far in each direction.
> 
> Since it works using a simple control character approach, it works recursively across ssh, screen and older systems really well. If you're a dev you can put it in your warn statements so when tailing logs it's easier to navigate to where you want to. If you work with grep/cat a lot, a simple sed command can make finding stuff much quicker and simpler.
> 
> The feature works quite well and I think a lot of people would like it. I hope some of you will take the time to try it out!
> 
> I'm casually requesting its integration into Konsole depending on how others feel, but if you don't like it, I enjoyed writing it and will still probably continue to use it myself.
> 
> I would also appreciate a code review of the work so that even if you don't want this feature, I don't introduce bugs into my own forks.
> 
> 
> Diffs
> -----
> 
>   desktop/sessionui.rc 67d89ae 
>   desktop/konsoleui.rc 1dd4f69 
>   src/Emulation.h 92a0ea7 
>   src/Emulation.cpp 02ed4be 
>   src/Session.h 9e982df 
>   src/Session.cpp e27bf78 
>   src/SessionController.h 2ff7910 
>   src/SessionController.cpp 62c1d0b 
>   src/Vt102Emulation.cpp 0b6d2ed 
> 
> Diff: http://git.reviewboard.kde.org/r/112983/diff/
> 
> 
> Testing
> -------
> 
> I'm not really sure how to do this. Some pointers would be very much appreciated. The feature does work though. :-)
> 
> 
> Thanks,
> 
> Phillip Taylor
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20131101/1cd91684/attachment.html>