[Konsole-devel] Review Request 110560: [ColorSchemeEditor improvements v3](part3+5): Transform ColorSchemeEditor class from Qwidget to Kdialog

[renan fargetton]

> On May 22, 2013, 1:22 p.m., Kurt Hindenburg wrote:
> > I figured out the issue w/ the new name - I'll commit this so it goes into 4.11 - please test it if you can.

Thanks, I'm quite busy this week and with no internet at night... I'll test as soon as I can.


- renan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110560/#review32962
-----------------------------------------------------------


On May 22, 2013, 1:36 p.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110560/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 1:36 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> What remains to submit : part3 and part5 (I keep part6 apart since I'm not sure you will want to get it)
> 
> - Transform ColorSchemeEditor class from Qwidget to Kdialog
>  - Move some code from EditProfileDialog::showColorSchemeEditor
>     * a part went into the newly created slot EditProfileDialog::saveColorScheme
>     * a part becomes obsolete since ColorSchemeEditor is the whole Kdialog
>     * a small part went into ColorSchemeEditor constructor
>  - Make  ColorSchemeEditor a non-modal dialog : The terminal is not frozen when the dialog is open
>  - The Kdialog has an Apply button
>  - Some safeguard to check that there is only one ColorSchemeEditor open
>  - Use reference rather than pointer in ColorSchemeEditor interface
> 
> 
> Diffs
> -----
> 
>   src/ColorSchemeEditor.h 11090d4 
>   src/ColorSchemeEditor.cpp 8ccbd7f 
>   src/EditProfileDialog.h 1f752af 
>   src/EditProfileDialog.cpp 98ae2e7 
> 
> Diff: http://git.reviewboard.kde.org/r/110560/diff/
> 
> 
> Testing
> -------
> 
> Compile / run
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130523/3b2ca8b0/attachment.html>