[Konsole-devel] Review Request 110536: [ColorSchemeEditor improvements v2](part6/6): Hide EditProfileDialog when ColorSchemeEditor is visible

[renan fargetton]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110536/
-----------------------------------------------------------

(Updated May 20, 2013, 4:08 p.m.)


Review request for Konsole.


Changes
-------

Styling issue : Fix a missing space after a comma


Description
-------

The last one of the serie.

Hide EditProfileDialog when opening ColorSchemeEditor.

I am not sure it is the usual way of doing it in KDE, but I think in this case it is better if the parent dialog is hidden when the user is tweaking a theme : I'm using it a lot, and I like to be able to get an idea of the result in the terminal when I change some color (is it looking nice ? Are contrast Okay ?...).

Before this patch the user gets up to 4 windows stacked one over the other : konsole main window / EditProfileDialog / ColorSchemeEditor / KColorDialog (when changing one color). Hiding EditProfileDialog makes it less crowded and easier to see the result in the terminal.


Diffs (updated)
-----

  src/EditProfileDialog.cpp 98ae2e7 

Diff: http://git.reviewboard.kde.org/r/110536/diff/


Testing
-------

Compile / run / used for several days


Thanks,

renan fargetton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/9490e717/attachment.html>