[Konsole-devel] Review Request 110560: [ColorSchemeEditor improvements v3](part3+5): Transform ColorSchemeEditor class from Qwidget to Kdialog

[renan fargetton]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110560/
-----------------------------------------------------------

(Updated May 20, 2013, 4:06 p.m.)


Review request for Konsole.


Changes
-------

Styling issue : Fix a missing space after a comma


Description
-------

What remains to submit : part3 and part5 (I keep part6 apart since I'm not sure you will want to get it)

- Transform ColorSchemeEditor class from Qwidget to Kdialog
 - Move some code from EditProfileDialog::showColorSchemeEditor
    * a part went into the newly created slot EditProfileDialog::saveColorScheme
    * a part becomes obsolete since ColorSchemeEditor is the whole Kdialog
    * a small part went into ColorSchemeEditor constructor
 - Make  ColorSchemeEditor a non-modal dialog : The terminal is not frozen when the dialog is open
 - The Kdialog has an Apply button
 - Some safeguard to check that there is only one ColorSchemeEditor open
 - Use reference rather than pointer in ColorSchemeEditor interface


Diffs (updated)
-----

  src/ColorSchemeEditor.h 11090d4 
  src/ColorSchemeEditor.cpp 8ccbd7f 
  src/EditProfileDialog.h 1f752af 
  src/EditProfileDialog.cpp 98ae2e7 

Diff: http://git.reviewboard.kde.org/r/110560/diff/


Testing
-------

Compile / run


Thanks,

renan fargetton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/2f31264c/attachment.html>