[Konsole-devel] Review Request 110533: [ColorSchemeEditor improvements v2](part3): Use reference rather than pointer in interface

[Kurt Hindenburg]

> On May 20, 2013, 1:33 p.m., Kurt Hindenburg wrote:
> > For code changes like you should include info about why you are making this change.  The code appears correct AFAIK; was there some reason you wanted it changed?
> 
> renan fargetton wrote:
>     The truth is that there is no strong reason for this change... In term of coding style, I find it more clean to use const reference in interface rather than const pointer.
>     
>     It is only that when I was cutting my changes in chunk I had this laying around... It is really not important : after part5 patch the method ColorSchemeEditor::colorScheme() is not used anywhere (but can still be kept in order to provide a clean interface)

Ok I'll leave it out for now


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110533/#review32815
-----------------------------------------------------------


On May 20, 2013, 3:54 a.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110533/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 3:54 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Use reference rather than pointer in ColorSchemeEditor interface
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.cpp f30856d 
>   src/ColorSchemeEditor.h 9b1e4b2 
>   src/ColorSchemeEditor.cpp 421f613 
> 
> Diff: http://git.reviewboard.kde.org/r/110533/diff/
> 
> 
> Testing
> -------
> 
> compile / run
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/defdc12d/attachment.html>