[Konsole-devel] Review Request 110534: [ColorSchemeEditor improvements v2](part4): Add isNewScheme in ColorSchemeEditor class

Commit Hook null at kde.org
Mon May 20 14:07:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110534/
-----------------------------------------------------------

(Updated May 20, 2013, 2:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole.


Description
-------

Add _isNewScheme bool as private member in ColorSchemeEditor class, making the dialog aware if it correspond to a new theme or not.

At this  point it may look not very usefull, but it will become more necessary with next patch it the serie, where more stuff is moved from EditProfile into this class. Still the code is quite indepedent so I splitted it in two patches.


Diffs
-----

  src/ColorSchemeEditor.h 9b1e4b2 
  src/ColorSchemeEditor.cpp 421f613 
  src/EditProfileDialog.cpp f30856d 

Diff: http://git.reviewboard.kde.org/r/110534/diff/


Testing
-------

compile / run


Thanks,

renan fargetton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/a343ae8e/attachment.html>


More information about the konsole-devel mailing list