[Konsole-devel] Review Request 110532: [ColorSchemeEditor improvements v2](part2): Minor styling issue + a few comments

Kurt Hindenburg kurt.hindenburg at gmail.com
Mon May 20 12:23:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110532/#review32810
-----------------------------------------------------------



src/ColorSchemeEditor.cpp
<http://git.reviewboard.kde.org/r/110532/#comment24358>

    Obvious comments like this are likely not needed



src/EditProfileDialog.cpp
<http://git.reviewboard.kde.org/r/110532/#comment24359>

    Just use // for inline comments


- Kurt Hindenburg


On May 20, 2013, 3:48 a.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110532/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 3:48 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Changing styling in accordance with KDE styling guidelines + adding a few comments
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.cpp f30856d 
>   src/ColorSchemeEditor.cpp 421f613 
> 
> Diff: http://git.reviewboard.kde.org/r/110532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/cd369ae8/attachment.html>


More information about the konsole-devel mailing list