[Konsole-devel] Review Request 110361: Improvement in ColorSchemeEditor dialog : Apply button

[renan fargetton]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110361/
-----------------------------------------------------------

(Updated May 20, 2013, 3:33 a.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Description
-------

The second half of the previous patch :
- add apply button
- try to fix the minor styling issues (but I may have forgotten some)

A remaining issue with the dialog is that it currently stop the application workflow : konsole terminal is frozen until the dialog close (i.e. exec() vs show() ). I would like to make this dialog non modal. I started working on it, and will submit a patch when its ready.


Diffs
-----

  src/ColorSchemeEditor.h 9b1e4b2 
  src/ColorSchemeEditor.cpp 421f613 
  src/EditProfileDialog.h 33b3930 
  src/EditProfileDialog.cpp 74b0237 

Diff: http://git.reviewboard.kde.org/r/110361/diff/


Testing
-------

compile / run


Thanks,

renan fargetton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/fb31ed4c/attachment.html>