[Konsole-devel] Review Request 109891: Add customizable display's contents margins

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109891/#review32340
-----------------------------------------------------------


I'm testing just the margin part using http://paste.kde.org/741482/

- Kurt Hindenburg


On April 17, 2013, 8 a.m., Mariusz Glebocki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109891/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 8 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Add customizable display's contents margins
>     
> Minor changes include possibility of centering the contents on the display, cleaner terminal's contents size and position related code (without magic numbers), better handling of a mouse over effect on links.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 33b3930 
>   src/EditProfileDialog.cpp 74b0237 
>   src/EditProfileDialog.ui 592370a 
>   src/Profile.h 596f78a 
>   src/Profile.cpp 14946ce 
>   src/TerminalDisplay.h 38ff997 
>   src/TerminalDisplay.cpp 29678d2 
>   src/ViewManager.cpp f700d5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109891/diff/
> 
> 
> Testing
> -------
> 
> Changing each margin size and toggling the contents centering option, then:
> * resizing the window
> * moving/hiding/scrolling the scrollbar
> * selecting a text
> * moving the cursor over links
> 
> 
> Thanks,
> 
> Mariusz Glebocki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130510/26f9f984/attachment.html>