[Konsole-devel] Review Request 110318: Improvements in ColorSchemeEditor dialog

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110318/#review32139
-----------------------------------------------------------



src/ColorSchemeEditor.cpp
<http://git.reviewboard.kde.org/r/110318/#comment23929>

    This will force the table to be vertical enough to show all the colors.  I don't see a reason to do this.


Thanks for the code and testing.  I think it would be best to split this up into smaller patches.  One for the table fixes and another for the save/apply.  There are also a few minor style issues but that's no big deal.  I'll see if I can get this in before the freeze this month.

- Kurt Hindenburg


On May 5, 2013, 3:45 p.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110318/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 3:45 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Improvements in ColorSchemeEditor dialog :
> - colorTable has one more row for intense colors. This way each color and the corresponding intense color is side by side (the data model colorScheme is unchanged, only the ui has the additional column)
> 
> - colorTable has fixed height such that the table fit exactly inside.
> 
> - an Apply button is added, so that it is possible to save modified ColorScheme directly from colorSchemeEditor dialog. This way it is easier to preview the result of the color theme change, no need to close/open the dialog to get the preview. 
>        * Most of the changes are in EditProfileDialog.cpp where the Kdialog is set up (EditProfileDialog::showColorSchemeEditor() ).
>        * Saving is done in a separated slot EditProfileDialog::saveColorScheme(const ColorScheme& scheme)
> 
> 
> Diffs
> -----
> 
>   src/ColorSchemeEditor.h 9b1e4b2 
>   src/ColorSchemeEditor.cpp e75cacb 
>   src/EditProfileDialog.h 33b3930 
>   src/EditProfileDialog.cpp 74b0237 
> 
> Diff: http://git.reviewboard.kde.org/r/110318/diff/
> 
> 
> Testing
> -------
> 
> Run it on my machine / create and modify colorSchemes with the dialog
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130506/bc87abed/attachment.html>