[Konsole-devel] Review Request 107640: Prevent the opening of two or more "edit profile dialogs" per session.

Commit Hook null at kde.org
Thu Mar 14 16:47:15 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated March 14, 2013, 4:47 p.m.)


This change has been marked as submitted.

Review request for Konsole.


Looking at the code, the best solution for the issue described in the bug is:

Fixing the wrong behaviour to open two or more "edit dialog" for one session/tab with 
the same profile (it should be fixed anyway and this is the issue of the bug 311270 ), 
and the crash with two or more "edit dialog", one for different session(tabs)
with the same profile.

With the patch:
one tab/session -> only one edit profile dialog at the same time ( 311270 )

tab1/session -> edit profile (profile1)
tab2/session -> edit profile (profile1)  
tab[i]/session -> edit profile (profile1)

many tab with the same profile, only one edit dialog is shown

NOTE:The issue(crash) appears only when transparency property is modified by one of the two profiles.

This addresses bug 311270.


  src/TerminalDisplay.cpp 8016c1e 
  src/TerminalDisplay.h 46058be 
  src/SessionController.h 97020fa 
  src/SessionController.cpp 25eb1ef 
  src/ManageProfilesDialog.cpp 3b270dc 
  src/EditProfileDialog.h 30d72e5 

Diff: http://git.reviewboard.kde.org/r/107640/diff/



Francesco Cecconi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130314/dbd64af9/attachment.html>

More information about the konsole-devel mailing list