[Konsole-devel] Review Request 109391: Blur konsole background if transparency has been set

[Mark Gaiser]

> On March 10, 2013, 6:02 p.m., Martin Gräßlin wrote:
> > This patch shows the same problem as any previous attempt to that problem. For a full record of the issues please see history of e.g. https://bugs.kde.org/show_bug.cgi?id=198175

Hi Martin,

The "record" is scattered throughout that bug report and there doesn't seem to be any summing up of how you would think this is acceptable.
So let me try to make a small summary of what seems to be the case.

1. Blurring the entire window should not be done (which is what i did in this patch).
2. Blurring should be done through the kpart from konsole.
3. You are apposed to that since you see a blurred konsole as a bug.
4. A config option should be added to allow blurring if the window is transparent.

The easy approach is the one i did here. It's not dependent on the kpart of konsole and works on an application basis. This means every other application using the console kpart will also have to (manually) add the one liner to add blurring.

Next up is a blur fundamental. In my opinion blur is meant to blur (partly) transparent areas on the desktop. Whatever ones opinion is about that. That makes it consistent and should be how it works. So for konsole the default (and i know you disagree here) should be blurred when it's partly transparent.

What i guess needs to happen is:
- Add in a config option (per profile) to enable/disable blur when there is some form of transparency.
- That option should be enabled by default as said for the above reasons of consistency.

Do you agree to those steps? The result would probably be like this: http://bugsfiles.kde.org/attachment.cgi?id=70130

Another possible alternative is probably to blur it be default without any option to change that. Then with custom window flags you could probably disable blur.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109391/#review28898
-----------------------------------------------------------


On March 10, 2013, 5:02 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109391/
> -----------------------------------------------------------
> 
> (Updated March 10, 2013, 5:02 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This has apparently been a request in bug #198175 for quite a few years. Which i only found out after making the patch.
> 
> This patch blurs the Konsole window background of the transparency has been set.
> 
> 
> This addresses bug 198175.
>     http://bugs.kde.org/show_bug.cgi?id=198175
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e9f7dea 
>   src/MainWindow.cpp 0ba82f0 
> 
> Diff: http://git.reviewboard.kde.org/r/109391/diff/
> 
> 
> Testing
> -------
> 
> Background is blurred just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130310/d12ca723/attachment.html>