[Konsole-devel] Review Request 104717: split view: automatically close the split area if it becomes empty.

[Francesco Cecconi]

> On May 9, 2013, 3:56 p.m., Kurt Hindenburg wrote:
> > I'm not sure what to do with - I'm almost inclined to just prevent the user from dragging out the last view

Hi Kurt, sorry for the delay. I have updated the patch for to prevent the drop of the last tab.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104717/#review32284
-----------------------------------------------------------


On July 27, 2013, 8:39 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104717/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 8:39 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> automatically close blank split, after that last tab is moved.
> 
> 
> This addresses bug 275771.
>     http://bugs.kde.org/show_bug.cgi?id=275771
> 
> 
> Diffs
> -----
> 
>   src/ViewContainer.h d5bdf73 
>   src/ViewContainer.cpp 63c187d 
>   src/ViewContainerTabBar.h 5b97abc 
>   src/ViewContainerTabBar.cpp c3a9dd1 
>   src/ViewManager.h f039a27 
>   src/ViewManager.cpp 4b9708e 
> 
> Diff: http://git.reviewboard.kde.org/r/104717/diff/
> 
> 
> Testing
> -------
> 
> - one tab + split + one tab -> move split right/left, no blank area
> - from bug: after step 4 no blank area
> 
> seems to work well but more test are necessary. ;)
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130727/cc7158a0/attachment.html>