[Konsole-devel] Review Request 108461: Make libKonq optional

[Francesco Cecconi]

> On Jan. 23, 2013, 12:06 a.m., Francesco Cecconi wrote:
> > src/CMakeLists.txt, line 5
> > <http://git.reviewboard.kde.org/r/108461/diff/3/?file=108681#file108681line5>
> >
> >     you should declare USE_LIBKONQ in src/config-konsole.h.cmake and to use this for the code.
> >     
> >     -> #cmakedefine USE_LIBKONQ 1
> >     
> >     Note: HAVE_LIBKONQ is a best default name

After this change, "cmake -DWITH_LibKonq=off .." will disable the libkonq feature.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108461/#review26041
-----------------------------------------------------------


On Jan. 22, 2013, 2:37 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108461/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 2:37 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I meant to do this earlier - this change allows konsole to build w/o libKonq - I've come across system w/o the libKonq installed.  You look the dnd menus w/o  libKonq.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7829e13 
>   src/TerminalDisplay.cpp a2c5621 
> 
> Diff: http://git.reviewboard.kde.org/r/108461/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130123/6a565ae9/attachment.html>