[Konsole-devel] Review Request 108461: Make libKonq optional

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108461/#review26037
-----------------------------------------------------------


I'm confused. 

Isn't the newest patch again or still making libkonq one automagic dependency ? 

We need to allow packagers/users to explicit disable the libkonq feature with something like "cmake -DUSE_LIBKONQ=off ..", even when libkonq is available in the building environment.

Beside that, the patch doesn't seem to work correctly. I just type "cmake .. ; make; make install" , then libkonq is detected, libkonsoleprivate.so linked to libkonq, but the feature is actually not built into.


"if defined(LIBKONQ_FOUND)", err, LIBKONQ_FOUND is known to cmake, but not known to the compiler.

- Jekyll Wu


On Jan. 22, 2013, 2:37 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108461/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 2:37 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I meant to do this earlier - this change allows konsole to build w/o libKonq - I've come across system w/o the libKonq installed.  You look the dnd menus w/o  libKonq.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7829e13 
>   src/TerminalDisplay.cpp a2c5621 
> 
> Diff: http://git.reviewboard.kde.org/r/108461/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130122/72995911/attachment.html>